On Wed, Jun 30, 2021 at 08:50:01AM -0700, Darrick J. Wong wrote: > > +# fcollapse need offset and len to be multiple of blocksize for filesystems > > +# hence make this test work with 64k blocksize as well. > ... > > What if the blocksize is 32k? ... or 8k? or 16k? (which might be more likely) How bout if we change the offsets and lengths in the test so they are all multiples of 64k, and adjusting 31.out appropriately? That will allow the test to work for block sizes up to 64k without needing to having a special case for 031.out.64k. I don't know of architectures with a page size > 64k (yet), so this should hold us for a while. - Ted