On Wed, Jun 30, 2021 at 12:32 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > On Wed, Jun 30, 2021 at 11:46 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > > On Wed, Jun 30, 2021 at 11:35:32AM +0300, Amir Goldstein wrote: > > > > > > Do you have feeling of dejavu? ;-) > > > https://lore.kernel.org/linux-fsdevel/20200730192537.GB13525@xxxxxxxxxxxxxx/ > > > > That was a year ago. I have trouble remembering emails I sent > > yesterday. > > > > > > > > We've been through this. > > > Maybe you silenced the smach warning on fsnotify() and the rename to > > > __fsnotifty() > > > caused this warning to refloat? > > > > Yes. Renaming the function will make it show up as a new warning. Also > > this is an email from the kbuild-bot and last years email was from me, > > so it's a different tool and a different record of sent messages. > > > > (IMO, you should really just remove the bogus NULL checks because > > everyone looking at the warning will think the code is buggy). > > > > I think the warning is really incorrect. > Why does it presume that event_info->dir is non-NULL? > Did smach check all the callers to fsnotify() or something? > What about future callers that will pass NULL, just like this one: > > https://lore.kernel.org/linux-fsdevel/20210629191035.681913-12-krisman@xxxxxxxxxxxxx/ > FWIW, the caller of this new helper passes NULL as inode: https://lore.kernel.org/linux-fsdevel/20210629191035.681913-14-krisman@xxxxxxxxxxxxx/ Thanks, Amir.
