Re: [PATCH] ext4: fix input checking in fs/jbd2/journal.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 07, 2021 at 05:55:58PM +0000, Leah Rumancik wrote:
> Update
> 
> 	if (JBD2_JOURNAL_FLUSH_DISCARD & !blk_queue_discard(q))
> 
> to use && instead of &. JBD2_JOURNAL_FLUSH_DISCARD is set to 1 so &
> technically works but && could be a bit faster and will maintain
> correctness in the event the value of JBD2_JOURNAL_FLUSH_DISCARD is
> updated.
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> Signed-off-by: Leah Rumancik <leah.rumancik@xxxxxxxxx>

Thanks, I've folded this fix into the base commit.

	     	    	     	      - Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux