On Thu, 27 May 2021, riteshh wrote:
> On 21/05/20 01:55PM, Lee Jones wrote:
>
> Hi Lee,
>
> Thanks for your patch. I see we could a little better here.
> There are several other checkpatch ERROR msgs in this file.
> Care to fix all of those ERRORS within the same patch itself?
I don't think it's a good idea to mix functionality within a single
patch. However, I would be happy to provide a follow-up solving these
issues for you.
> ./scripts/checkpatch.pl -f fs/ext4/namei.c | sed -n '/ERROR/,/^$/p'
>
> e.g. to list a few of them -
> ERROR: do not use assignment in if condition
> #1605: FILE: fs/ext4/namei.c:1605:
> + if ((bh = bh_use[ra_ptr++]) == NULL)
>
> ERROR: space required after that ',' (ctx:VxV)
> #1902: FILE: fs/ext4/namei.c:1902:
> + struct buffer_head **bh,struct dx_frame *frame,
> ^
>
> ERROR: space required after that ',' (ctx:VxV)
> #2249: FILE: fs/ext4/namei.c:2249:
> + de = do_split(handle,dir, &bh2, frame, &fname->hinfo);
> ^
>
> ERROR: spaces required around that '=' (ctx:VxV)
> #2288: FILE: fs/ext4/namei.c:2288:
> + int dx_fallback=0;
>
> -ritesh
>
> > Cc: "Theodore Ts'o" <tytso@xxxxxxx>
> > Cc: Andreas Dilger <adilger.kernel@xxxxxxxxx>
> > Cc: Remy Card <card@xxxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxxxxx>
> > Cc: linux-ext4@xxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> > fs/ext4/namei.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> > index afb9d05a99bae..7e780cf311c5a 100644
> > --- a/fs/ext4/namei.c
> > +++ b/fs/ext4/namei.c
> > @@ -1899,7 +1899,7 @@ static struct ext4_dir_entry_2 *dx_pack_dirents(struct inode *dir, char *base,
> > * Returns pointer to de in block into which the new entry will be inserted.
> > */
> > static struct ext4_dir_entry_2 *do_split(handle_t *handle, struct inode *dir,
> > - struct buffer_head **bh,struct dx_frame *frame,
> > + struct buffer_head **bh, struct dx_frame *frame,
> > struct dx_hash_info *hinfo)
> > {
> > unsigned blocksize = dir->i_sb->s_blocksize;
> > @@ -2246,7 +2246,7 @@ static int make_indexed_dir(handle_t *handle, struct ext4_filename *fname,
> > if (retval)
> > goto out_frames;
> >
> > - de = do_split(handle,dir, &bh2, frame, &fname->hinfo);
> > + de = do_split(handle, dir, &bh2, frame, &fname->hinfo);
> > if (IS_ERR(de)) {
> > retval = PTR_ERR(de);
> > goto out_frames;
> >
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
