On Thu, May 06, 2021 at 05:21:10PM -0700, Harshad Shirwadkar wrote: > From: Harshad Shirwadkar <harshadshirwadkar@xxxxxxxxx> > > Fast commit related struct ext4_fc_tl can be unaligned on disk. So, > while accessing that we should ensure that the pointers are > aligned. This patch fixes unaligned accesses to ext4_fc_tl and also > gets rid of macros fc_for_each_tl and ext4_fc_tag_val that may result > in unaligned accesses to struct ext4_fc_tl. > > Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@xxxxxxxxx> Looks good. I wrote my reply with a proposed version of ext4_fc_tag_val() before I saw your patch. This patch wasn't enough to fix the sparc64 crash, but after doing some additional investigation, I was able to figure out how to fix things so that j_recovery_fast_commit is working on sparc64. Patch follows on this thread... - Ted
