On Tue 13-04-21 14:05:12, Christoph Hellwig wrote: > On Tue, Apr 13, 2021 at 01:28:49PM +0200, Jan Kara wrote: > > Use i_mapping_sem instead of XFS internal i_mmap_lock. The intended > > purpose of i_mapping_sem is exactly the same. > > Might be worth mentioning here that the locking in __xfs_filemap_fault > changes because filemap_fault already takes i_mapping_sem? Sure, will add. > > > * mmap_lock (MM) > > * sb_start_pagefault(vfs, freeze) > > - * i_mmaplock (XFS - truncate serialisation) > > + * i_mapping_sem (XFS - truncate serialisation) > > This is sort of VFS now, isn't it? Right, I'll update the comment. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
