On Tue, Mar 30, 2021 at 05:15:33PM +0200, Jan Kara wrote: > On Mon 22-03-21 11:21:38, Arnd Bergmann wrote: > > From: Arnd Bergmann <arnd@xxxxxxxx> > > > > Building with 'make W=1' shows a harmless -Wempty-body warning: > > > > fs/jbd2/recovery.c: In function 'fc_do_one_pass': > > fs/jbd2/recovery.c:267:75: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > > 267 | jbd_debug(3, "Fast commit replay failed, err = %d\n", err); > > | ^ > > > > Change the empty dprintk() macros to no_printk(), which avoids this > > warning and adds format string checking. > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > Sure. Feel free to add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> Applied, thanks. - Ted
