On Sun, Mar 21, 2021 at 11:31 AM Theodore Ts'o <tytso@xxxxxxx> wrote: > > zhangyi (F) (3): > ext4: find old entry again if failed to rename whiteout > ext4: do not iput inode under running transaction in ext4_rename() > ext4: do not try to set xattr into ea_inode if value is empty Side note: this is obviously entirely up to the author, but I think it would be nice if we would encourage people to use their native names if/when they want to. Maybe this "zhangyi (F)" is how they _want_ to write their name in the kernel, and that's obviously fine if so. But at the same time, coming from Finland, I remember how people who had the "odd" characters (åäö) in their name ended up replacing them with the US-ASCII version (generally "aa" "ae" and "oe"), and it always just looked bad to a native speaker. Particularly annoying in public contexts. At the same time, for the same reason, I can also understand people not wanting to even expose those characters at all, because then non-native speakers invariably messed it up even worse... Anyway, I think and hope that we have the infrastructure to do it right not just for Latin1, but the more complex non-Western character sets too. And as a result should possibly encourage people to use their native names if they want to. At least make people aware that it _should_ work. Again, maybe I'm barking up the wrong tree, and in this case "zhangyi (F) <yi.zhang@xxxxxxxxxx>" is just what zhangyi prefers simply because it's easier/more convenient. But I just wanted to mention it, because we _do_ have examples of it working. Not many, but some: git log --pretty="%an" --since=2.years | sort -u | tail including examples of having the Westernized name in parenthesis for the "use that one if you can't do the real one" case.. Linus