On Wed, Mar 17, 2021 at 12:19 AM Harshad Shirwadkar <harshadshirwadkar@xxxxxxxxx> wrote: > > This patch adds rename whiteout support in fast commits. Note that the My only problem with this change is the subject. It sounds like rename whiteout was not possible and now support was added and it is now possible. This is not the case. The truth is that rename whiteout is supported but broken with fast commits. So the subject should reflect that this is a FIX commit, i.e.: "ext4: fix rename whiteout with fast commit" And patch should have a Fixes: tag with the commit that added fast commit support to rename. Otherwise, patch has stray newline but the rest looks pretty straightforward to me. Thanks, Amir.
