Re: [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Eric Biggers <ebiggers@xxxxxxxxxx>
Subject: Re: [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time()
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 11 Jan 2021 11:52:01 +0100
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, "Theodore Ts'o" <tytso@xxxxxxx>, Christoph Hellwig <hch@xxxxxx>
In-reply-to: <20210109075903.208222-5-ebiggers@kernel.org>
References: <20210109075903.208222-1-ebiggers@kernel.org> <20210109075903.208222-5-ebiggers@kernel.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Fri, Jan 08, 2021 at 11:58:55PM -0800, Eric Biggers wrote:
> +	if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false))
> +		dirty_flags |= I_DIRTY_SYNC;

fat does not support i_version updates, so this bit can be skipped.

Follow-Ups:
- Re: [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time()
  - From: Eric Biggers

References:
- [PATCH v2 00/12] lazytime fix and cleanups
  - From: Eric Biggers
- [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time()
  - From: Eric Biggers

Prev by Date: Re: [PATCH v2 01/12] fs: fix lazytime expiration handling in __writeback_single_inode()
Next by Date: Re: [PATCH v2 08/12] fs: drop redundant check from __writeback_single_inode()
Previous by thread: [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time()
Next by thread: Re: [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time()
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]