Hi Chengguang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10 next-20201223] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chengguang-Xu/ext2-implement-page_mkwrite/20201218-214646 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a409ed156a90093a03fe6a93721ddf4c591eac87 config: i386-randconfig-s002-20201217 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-184-g1b896707-dirty # https://github.com/0day-ci/linux/commit/24259119fbeffce3b221c39c3b8bc0f2d5b1e750 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Chengguang-Xu/ext2-implement-page_mkwrite/20201218-214646 git checkout 24259119fbeffce3b221c39c3b8bc0f2d5b1e750 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> "sparse warnings: (new ones prefixed by >>)" >> fs/ext2/file.c:33:12: sparse: sparse: symbol 'ext2_page_mkwrite' was not declared. Should it be static? >> fs/ext2/file.c:50:35: sparse: sparse: symbol 'ext2_vm_ops' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
