Hi Chengguang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10 next-20201218] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chengguang-Xu/ext2-implement-page_mkwrite/20201218-214646 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a409ed156a90093a03fe6a93721ddf4c591eac87 config: x86_64-randconfig-p001-20201217 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/24259119fbeffce3b221c39c3b8bc0f2d5b1e750 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Chengguang-Xu/ext2-implement-page_mkwrite/20201218-214646 git checkout 24259119fbeffce3b221c39c3b8bc0f2d5b1e750 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> fs/ext2/file.c:33:12: warning: no previous prototype for 'ext2_page_mkwrite' [-Wmissing-prototypes] 33 | vm_fault_t ext2_page_mkwrite(struct vm_fault *vmf) | ^~~~~~~~~~~~~~~~~ vim +/ext2_page_mkwrite +33 fs/ext2/file.c 32 > 33 vm_fault_t ext2_page_mkwrite(struct vm_fault *vmf) 34 { 35 struct vm_area_struct *vma = vmf->vma; 36 struct inode *inode = file_inode(vma->vm_file); 37 int err; 38 39 if (unlikely(IS_IMMUTABLE(inode))) 40 return VM_FAULT_SIGBUS; 41 42 sb_start_pagefault(inode->i_sb); 43 file_update_time(vma->vm_file); 44 err = block_page_mkwrite(vma, vmf, ext2_get_block); 45 sb_end_pagefault(inode->i_sb); 46 47 return block_page_mkwrite_return(err); 48 } 49 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip