On Thu, Oct 15, 2020 at 11:27:31AM +0200, Jan Kara wrote: > On Wed 14-10-20 18:56:13, Andreas Dilger wrote: > > On Oct 13, 2020, at 7:38 AM, Jan Kara <jack@xxxxxxx> wrote: > > > > > > Explain which valid block sizes mke2fs supports in more detail. > > > > > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > > > Should this mention that the default block size is 4096 bytes for most > > filesystems? > > That would be to the "heuristic" parts. Yes, I agree, I'll add that. > > > It might mention e.g. ppc64 or aarch64 can use 64KB page size, but this > > is definitely an improvement already. > > Yeah, I can add that to the "page size" part. But with these archs there's > a catch that page size can be configured in the kernel config so the > formulation will need to be a bit more careful. But I'll add something. > > > Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx> > > Thanks! I'll send v2. Did you ever send a v2 of this patch? I can't seem to find it in my archives or in patchwork. Thanks!! - Ted
