Re: [PATCH] ext4: remove the unused EXT4_CURRENT_REV macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu 12-11-20 14:56:42, xiakaixu1987@xxxxxxxxx wrote:
> From: Kaixu Xia <kaixuxia@xxxxxxxxxxx>
> 
> There are no callers of the EXT4_CURRENT_REV macro, so remove it.
> 
> Signed-off-by: Kaixu Xia <kaixuxia@xxxxxxxxxxx>

I guess this has fallen through the cracks? The cleanup looks good to me.
You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/ext4/ext4.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index bf9429484462..cf1c01139f26 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1858,7 +1858,6 @@ static inline bool ext4_verity_in_progress(struct inode *inode)
>  #define EXT4_GOOD_OLD_REV	0	/* The good old (original) format */
>  #define EXT4_DYNAMIC_REV	1	/* V2 format w/ dynamic inode sizes */
>  
> -#define EXT4_CURRENT_REV	EXT4_GOOD_OLD_REV
>  #define EXT4_MAX_SUPP_REV	EXT4_DYNAMIC_REV
>  
>  #define EXT4_GOOD_OLD_INODE_SIZE 128
> -- 
> 2.20.0
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux