Thanks Ted :) -----Original Message----- From: Theodore Y. Ts'o [mailto:tytso@xxxxxxx] Sent: Thursday, December 03, 2020 10:11 PM To: Jan Kara <jack@xxxxxxx> Cc: tianxianting (RD) <tian.xianting@xxxxxxx>; adilger.kernel@xxxxxxxxx; linux-ext4@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH] ext4: remove the null check of bio_vec page On Wed, Oct 21, 2020 at 12:25:03PM +0200, Jan Kara wrote: > On Tue 20-10-20 16:22:01, Xianting Tian wrote: > > bv_page can't be NULL in a valid bio_vec, so we can remove the NULL > > check, as we did in other places when calling > > bio_for_each_segment_all() to go through all bio_vec of a bio. > > > > Signed-off-by: Xianting Tian <tian.xianting@xxxxxxx> > > Thanks for the patch. It looks good to me. You can add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> Applied, thanks. - Ted