Thanks Jan Hi Ted Tso, Could I get your opinion of this patch? thanks -----Original Message----- From: Jan Kara [mailto:jack@xxxxxxx] Sent: Saturday, October 24, 2020 12:57 AM To: tianxianting (RD) <tian.xianting@xxxxxxx> Cc: Jan Kara <jack@xxxxxxx>; tytso@xxxxxxx; adilger.kernel@xxxxxxxxx; linux-ext4@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH] ext4: remove the null check of bio_vec page On Fri 23-10-20 16:38:16, Tianxianting wrote: > Thanks Jan > Can be the patch applied? Ted Tso is the ext4 maintainer so he should eventually pick up and apply the patch. But since there's merge window currently open, I guess he's busy shuffling patches to send to Linus. I'd expect he'll get to your patch in a week or two. Honza > > -----Original Message----- > From: Jan Kara [mailto:jack@xxxxxxx] > Sent: Wednesday, October 21, 2020 6:25 PM > To: tianxianting (RD) <tian.xianting@xxxxxxx> > Cc: tytso@xxxxxxx; adilger.kernel@xxxxxxxxx; jack@xxxxxxx; > linux-ext4@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] ext4: remove the null check of bio_vec page > > On Tue 20-10-20 16:22:01, Xianting Tian wrote: > > bv_page can't be NULL in a valid bio_vec, so we can remove the NULL > > check, as we did in other places when calling > > bio_for_each_segment_all() to go through all bio_vec of a bio. > > > > Signed-off-by: Xianting Tian <tian.xianting@xxxxxxx> > > Thanks for the patch. It looks good to me. You can add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> > > Honza > > > --- > > fs/ext4/page-io.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index > > defd2e10d..cb135a944 100644 > > --- a/fs/ext4/page-io.c > > +++ b/fs/ext4/page-io.c > > @@ -111,9 +111,6 @@ static void ext4_finish_bio(struct bio *bio) > > unsigned under_io = 0; > > unsigned long flags; > > > > - if (!page) > > - continue; > > - > > if (fscrypt_is_bounce_page(page)) { > > bounce_page = page; > > page = fscrypt_pagecache_page(bounce_page); > > -- > > 2.17.1 > > > -- > Jan Kara <jack@xxxxxxxx> > SUSE Labs, CR -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
