On Fri, Nov 20, 2020 at 11:15:56AM -0800, Harshad Shirwadkar wrote: > This patch adds information about fast commit feature in mke2fs and > tune2fs man pages. > > Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@xxxxxxxxx> So this is a bit more of a personal preference thing, but I like to keep the libext2fs changes from the changes to the userspace applications, and then combine the changes to the userspace progams (mke2fs and tune2fs in this case) with the man page updates. So you might want to consider moving the mke2fs and tune2fs changes from the previous patch and then combining them with this patch, and adjusting the commit message appropriately? > diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in > index e6bfc6d6..2833b408 100644 > --- a/misc/mke2fs.8.in > +++ b/misc/mke2fs.8.in > @@ -521,6 +521,27 @@ The size of the journal must be at least 1024 filesystem blocks > and may be no more than 10,240,000 filesystem blocks or half the total > file system size (whichever is smaller) > .TP > +.BI fast_commit_size= fast-commit-size > +Create an additional fast commit journal area of size > +.I fast-commit-size > +kilobytes. > +This option is only valid if > +.B fast_commit > +feature is enabled > +on the file system. If this option is not specified and if > +.B fast_commit > +feature is turned on, fast commit area size defaults to > +.I journal-size > +/ 64 megabytes. The total size of the journal with > +.B fast_commit > +feature set is > +.I journal-size > ++ ( > +.I fast-commit-size > +* 1024) megabytes. The total journal size may be no more than > +10,240,000 filesystem blocks or half the total file system size > +(whichever is smaller). > +.TP So as I recall, aren't we currently calculating the fast commit size as a fraction of the total journal size? I'm not sure this is in sync with was in the last patch. - Ted
