On Thu, Nov 26, 2020 at 03:04:55PM +0800, Chao Yu wrote: > On 2020/11/25 8:23, Eric Biggers wrote: > > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > > > Since encrypted directories can be opened without their encryption key > > being available, and each readdir tries to set up the key, trying to set > > readdir -> readdir/lookup? Yes, ->lookup() tries to set up the key too. It's different because ->lookup() doesn't require that the directory be open. But I suppose that's another reason why setting up the directory's key in ->open() isn't useful. I'll add something about that. - Eric > > > up the key in ->open() too isn't really useful. > > > > Just remove it so that directories don't need an ->open() method > > anymore, and so that we eliminate a use of fscrypt_get_encryption_info() > > (which I'd like to stop exporting to filesystems). > > > > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> > > Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx> > > Thanks,