Re: [PATCH v3 07/38] mount: attach mappings to mounts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH v3 07/38] mount: attach mappings to mounts
From: Tycho Andersen <tycho@tycho.pizza>
Date: Tue, 1 Dec 2020 08:25:56 -0500
Cc: Christian Brauner <christian.brauner@xxxxxxxxxx>, Lennart Poettering <lennart@xxxxxxxxxxxxxx>, Mimi Zohar <zohar@xxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, containers@xxxxxxxxxxxxxxxxxxxxxxxxxx, Paul Moore <paul@xxxxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, smbarber@xxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Alban Crequy <alban@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Mrunal Patel <mpatel@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, selinux@xxxxxxxxxxxxxxx, Josh Triplett <josh@xxxxxxxxxxxxxxxx>, Seth Forshee <seth.forshee@xxxxxxxxxxxxx>, Aleksa Sarai <cyphar@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, Geoffrey Thomas <geofft@xxxxxxxxxxxxx>, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, John Johansen <john.johansen@xxxxxxxxxxxxx>, Theodore Tso <tytso@xxxxxxx>, Dmitry Kasatkin <dmitry.kasatkin@xxxxxxxxx>, Stephen Smalley <stephen.smalley.work@xxxxxxxxx>, fstests@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, linux-api@xxxxxxxxxxxxxxx, Casey Schaufler <casey@xxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-integrity@xxxxxxxxxxxxxxx, Todd Kjos <tkjos@xxxxxxxxxx>
In-reply-to: <20201201105025.GF27730@lst.de>
References: <20201128213527.2669807-1-christian.brauner@ubuntu.com> <20201128213527.2669807-8-christian.brauner@ubuntu.com> <20201201105025.GF27730@lst.de>

On Tue, Dec 01, 2020 at 11:50:25AM +0100, Christoph Hellwig wrote:
> The READ_ONCE still looks suspect as it generally needs to be paired
> with a WRITE_ONCE.  The rest looks sane to me.

Yeah, the comment from the other location is,

/* Pairs with smp_load_acquire() in mnt_user_ns(). */

So I think it's just a typo that needs to be fixed.

Tycho

References:
- [PATCH v3 00/38] idmapped mounts
  - From: Christian Brauner
- [PATCH v3 07/38] mount: attach mappings to mounts
  - From: Christian Brauner
- Re: [PATCH v3 07/38] mount: attach mappings to mounts
  - From: Christoph Hellwig

Prev by Date: [PATCH v2] generic: ENOSPC regression test in a multi-threaded scenario
Next by Date: Re: [PATCH 000/141] Fix fall-through warnings for Clang
Previous by thread: Re: [PATCH v3 07/38] mount: attach mappings to mounts
Next by thread: Re: [PATCH v3 07/38] mount: attach mappings to mounts
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]