> +int vfs_rename(struct renamedata *rd) > { > int error; > struct user_namespace *user_ns = &init_user_ns; > + struct inode *old_dir = rd->old_dir, *new_dir = rd->new_dir; > + struct dentry *old_dentry = rd->old_dentry, > + *new_dentry = rd->new_dentry; This looks weird. I'd just write the obvious: struct dentry *old_dentry = rd->old_dentry; struct dentry *new_dentry = rd->new_dentry;