On Wed, Nov 18, 2020 at 04:30:32PM +0100, Jan Kara wrote: > The idea of the warning in ext4_update_dx_flag() is that we should warn > when we are clearing EXT4_INODE_INDEX on a filesystem with metadata > checksums enabled since after clearing the flag, checksums for internal > htree nodes will become invalid. So there's no need to warn (or actually > do anything) when EXT4_INODE_INDEX is not set. > > Reported-by: Eric Biggers <ebiggers@xxxxxxxxxx> > Fixes: 48a34311953d ("ext4: fix checksum errors with indexed dirs") > Signed-off-by: Jan Kara <jack@xxxxxxx> Looks good, Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx> - Eric