On Thu, Oct 29, 2020 at 11:46:36PM +0800, xiakaixu1987@xxxxxxxxx wrote:
> From: Kaixu Xia <kaixuxia@xxxxxxxxxxx>
>
> The macro MOPT_Q is used to indicates the mount option is quota stuff and
> would be the same as MOPT_NOSUPPORT when CONFIG_QUOTA is disabled. We want
> to report NOSUPPORT error message when setting usrjquota or grpjquota
> options with the CONFIG_QUOTA is disabled, but now it report nothing. So
> fix it by adding the MOPT_STRING flag.
>
> Signed-off-by: Kaixu Xia <kaixuxia@xxxxxxxxxxx>
Thanks, applied with an improved commit description:
The macro MOPT_Q is used to indicates the mount option is related
to quota stuff and is defined to be MOPT_NOSUPPORT when
CONFIG_QUOTA is disabled. Normally the quota options are handled
explicitly, so it didn't matter that the MOPT_STRING flag was
missing, even though the usrjquota and grpjquota mount options
take a string argument. It's important that's present in the
!CONFIG_QUOTA case, since without MOPT_STRING, the mount option
matcher will match usrjquota= followed by an integer, and will
otherwise skip the table entry, and so "mount option not
supported" error message is never reported.
- Ted
