On Fri, Oct 30, 2020 at 05:45:56PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
>
> I_CREATING isn't actually set until the inode has been assigned an inode
> number and inserted into the inode hash table. So the WARN_ON() in
> fscrypt_setup_iv_ino_lblk_32_key() is wrong, and it can trigger when
> creating an encrypted file on ext4. Remove it.
>
> This was sometimes causing xfstest generic/602 to fail on ext4. I
> didn't notice it before because due to a separate oversight, new inodes
> that haven't been assigned an inode number yet don't necessarily have
> i_ino == 0 as I had thought, so by chance I never saw the test fail.
>
> Fixes: a992b20cd4ee ("fscrypt: add fscrypt_prepare_new_inode() and fscrypt_set_context()")
> Reported-by: Theodore Y. Ts'o <tytso@xxxxxxx>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
Applied to fscrypt.git#for-stable for 5.10.
- Eric
