On Nov 2, 2020, at 7:29 PM, Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx> wrote:
>
> It takes xattr_sem to check inline data again but without unlock it
> in case not have. So unlock it before return.
>
> Fixes: aef1c8513c1f ("ext4: let ext4_truncate handle inline data correctly")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Cc: Tao Ma <boyu.mt@xxxxxxxxxx>
> Signed-off-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>
Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>
> ---
> fs/ext4/inline.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
> index caa5147..b41512d 100644
> --- a/fs/ext4/inline.c
> +++ b/fs/ext4/inline.c
> @@ -1880,6 +1880,7 @@ int ext4_inline_data_truncate(struct inode *inode, int *has_inline)
>
> ext4_write_lock_xattr(inode, &no_expand);
> if (!ext4_has_inline_data(inode)) {
> + ext4_write_unlock_xattr(inode, &no_expand);
> *has_inline = 0;
> ext4_journal_stop(handle);
> return 0;
> --
> 1.8.3.1
>
Cheers, Andreas
Attachment:
signature.asc
Description: Message signed with OpenPGP
