Re: [PATCH v2 1/2] ext4: add helpers for checking whether quota can be enabled/is journalled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 19 Oct 2020, Jan Kara wrote:

On Mon 19-10-20 11:37:06, Jan Kara wrote:
On Sun 18-10-20 05:02:26, Roman Anufriev wrote:
Right now, there are several places, where we check whether fs is
capable of enabling quota or if quota is journalled with quite long
and non-self-descriptive condition statements.

This patch wraps these statements into helpers for better readability
and easier usage.

Signed-off-by: Roman Anufriev <dotdot@xxxxxxxxxxxxxx>

Looks good to me. You can add:

Reviewe-by: Jan Kara <jack@xxxxxxx>

Now I've realized that if we run in nojournal mode, quota won't be
journalled in any case. Probably not a configuration you run in but still
we should get that right.

I forgot about this case. Fixed in v4:
https://lore.kernel.org/linux-ext4/1603336860-16153-1-git-send-email-dotdot@xxxxxxxxxxxxxx/

								Roman



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux