Thanks Jan for taking a look at the patches. On Wed, Oct 21, 2020 at 9:04 AM Jan Kara <jack@xxxxxxx> wrote: > > On Thu 15-10-20 13:37:53, Harshad Shirwadkar wrote: > > + * - EXT4_FC_TAG_CREAT > > + - Create directory entry for a newly created file > > + - ``struct ext4_fc_dentry_info`` > > + - Stores the parent inode numer, inode number and directory entry of the > ^^^ number Ack > > > + newly created file > > + * - EXT4_FC_TAG_LINK > > + - Link a directory entry to an inode > > + - ``struct ext4_fc_dentry_info`` > > + - Stores the parent inode numer, inode number and directory entry > ^^^^ number Ack > > BTW, how is EXT4_FC_TAG_CREAT different from EXT4_FC_TAG_LINK? It seems > like they describe essentially the same operation? In the replay path, creat has to do certain things that link doesn't. For example, "creat" needs to mark the inode as used in the bitmap and also if it's a directory that's being created, it needs to initialize the "." and ".." dirents in the directory. That's why we need different tags. > > > + * - EXT4_FC_TAG_UNLINK > > + - Unink a directory entry of an inode > ^^^^ Unlink Ack Thanks, Harshad > > Honza > -- > Jan Kara <jack@xxxxxxxx> > SUSE Labs, CR
