On Oct 1, 2020, at 11:08 AM, Theodore Y. Ts'o <tytso@xxxxxxx> wrote: > > On Thu, Oct 01, 2020 at 10:58:09AM -0400, Theodore Y. Ts'o wrote: >> On Sun, Jul 19, 2020 at 05:00:33AM -0600, Andreas Dilger wrote: >>> A couple of tests use perl only for generating a string of >>> N characters long. Instead of requiring perl to run a few >>> tests, use shell built-in commands and don't repeatedly run >>> a separate subshell just to get a string of characters. >>> h >>> Signed-off-by: Andreas Dilger <adilger@xxxxxxxxx> >> >> Thanks, applied. > > .... and I have to revert the patch. It's using a non-standard shell > construction which fails on strict POSIX compliant shells, such as > dash. Could you please point out which constructs it is unhappy with? I had an earlier version of the patch using a different mechanism, but then updated it after feedback from Lukas. Cheers, Andreas
Attachment:
signature.asc
Description: Message signed with OpenPGP
