On Aug 7, 2020, at 8:01 AM, brookxu <brookxu.cn@xxxxxxxxx> wrote:
>
> Fix log printing of ext4_mb_regular_allocator()，it may be an
> unintentional behavior.
>
> Signed-off-by: Chunguang Xu <brookxu@xxxxxxxxxxx>
The debug message would probably be more useful if it included some
actual information (PID, status, fe_group, fe_start, fe_len), but
that isn't necessarily a problem with this patch itself.
Reviewed-by: Andreas Dilger <adilger@xxxxxxxx>
> ---
> fs/ext4/mballoc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 5d4a1be..b0da525 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2324,15 +2324,14 @@ static int ext4_mb_good_group_nolock(struct ext4_allocation_context *ac,
> * We've been searching too long. Let's try to allocate
> * the best chunk we've found so far
> */
> -
> ext4_mb_try_best_found(ac, &e4b);
> if (ac->ac_status != AC_STATUS_FOUND) {
> /*
> * Someone more lucky has already allocated it.
> * The only thing we can do is just take first
> * found block(s)
> - printk(KERN_DEBUG "EXT4-fs: someone won our chunk\n");
> */
> + mb_debug(sb, "EXT4-fs: someone won our chunk\n");
> ac->ac_b_ex.fe_group = 0;
> ac->ac_b_ex.fe_start = 0;
> ac->ac_b_ex.fe_len = 0;
> --
> 1.8.3.1
Cheers, Andreas
Attachment:
signature.asc
Description: Message signed with OpenPGP
