On Tue 21-07-20 12:38:55, Lukas Czerner wrote: > > @@ -270,19 +272,19 @@ int ext4_setup_system_zone(struct super_block *sb) > > ((i < 5) || ((i % flex_size) == 0))) > > add_system_zone(system_blks, > > ext4_group_first_block_no(sb, i), > > - ext4_bg_num_gdb(sb, i) + 1); > > + ext4_bg_num_gdb(sb, i) + 1, 0); > > Is there a good reason we don't check the return value, it can still > fail right ? Yes, it can. I'll add a patch to the series that fixes this. > Other than that the patch looks good to me. > > Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx> Thanks for review! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR