Re: ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/27/20 7:24 AM, brookxu wrote:
Delete the invalid BUGON in ext4_mb_load_buddy_gfp(), the previous
code has already judged whether page is NULL.

Signed-off-by: Chunguang Xu <brookxu@xxxxxxxxxxx>

Thanks for the patch. LGTM. Feel free to add.
Reviewed-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx>

---
  fs/ext4/mballoc.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 28a139f..9b1c3ad 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1279,9 +1279,6 @@ int ext4_mb_init_group(struct super_block *sb, ext4_group_t group, gfp_t gfp)
      e4b->bd_buddy_page = page;
      e4b->bd_buddy = page_address(page) + (poff * sb->s_blocksize);
-    BUG_ON(e4b->bd_bitmap_page == NULL);
-    BUG_ON(e4b->bd_buddy_page == NULL);
-
      return 0;
 err:




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux