On 6/29/20 5:56 PM, Yi Zhuang wrote:
If dquot_initialize() return non-zero and trace of ext4_unlink_enter/exit enabled then the matching-pair of trace_exit will lost in log. v2: Change the new label to be "out_trace:", which makes it more clear that it is undoing the "trace" part of the code. At the same time, fix other similar problems in this function: bh = ext4_find_entry(dir, &dentry->d_name, &de, NULL); if (IS_ERR(bh)) return PTR_ERR(bh); if (!bh) goto end_unlink; According to Andreas' suggestion, split up the "end_unlink:" label becomes two separate labels, and then remove the "if (handle)" check, and then use out_bh: before the handle is started. Signed-off-by: Yi Zhuang <zhuangyi1@xxxxxxxxxx>
Nice cleanup. Feel free to add: Reviewed-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx>
