On 7/3/20 6:20 PM, Jan Kara wrote:
On Thu 02-07-20 17:56:36, Chengguang Xu wrote:
ext2_blks_to_allocate() only counts direct blocks need to be allocated,
return value does not include indirect blocks.
Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxxxx>
---
fs/ext2/inode.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index c8b371c82b4f..4df849e694dd 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -355,9 +355,6 @@ static inline ext2_fsblk_t ext2_find_goal(struct inode *inode, long block,
* @k: number of blocks need for indirect blocks
* @blks: number of data blocks to be mapped.
* @blocks_to_boundary: the offset in the indirect block
- *
- * return the total number of blocks to be allocate, including the
- * direct and indirect blocks.
You're right the comment is wrong but instead of deleting it, I'd rather
fix it like: "Return the number of direct blocks to allocate."
That's fine, I can resend it with another comment fix together.
Thanks,
cgxu