On Wed, Jun 17, 2020 at 01:03:14AM -0700, Christoph Hellwig wrote: > On Tue, Jun 16, 2020 at 04:21:23PM -0400, Masayoshi Mizuma wrote: > > From: Masayoshi Mizuma <m.mizuma@xxxxxxxxxxxxxx> > > > > /proc/mounts doesn't show 'i_version' even if iversion > > mount option is set to XFS. > > > > iversion mount option is a VFS option, not ext4 specific option. > > Move the handler to show_sb_opts() so that /proc/mounts can show > > 'i_version' on not only ext4 but also the other filesystem. > > SB_I_VERSION is a kernel internal flag. XFS doesn't have an i_version > mount option. Thank you for pointing it out, I misunderstood that for XFS. iversion mount option is a VFS option, so I think it's good to show 'i_version' on /proc/mounts if the filesystem has i_version feature, like as: $ cat /proc/mounts ... /dev/vdb1 /mnt xfs rw,i_version,relatime,attr2,inode64,logbufs=8,logbsize=32k,noquota 0 0 ... - Masa
