On Tue, May 12, 2020 at 10:13:12AM -0400, Sasha Levin wrote: > On Tue, May 12, 2020 at 02:59:31PM +0200, Greg KH wrote: > > On Tue, May 12, 2020 at 06:20:05PM +0530, Ritesh Harjani wrote: > > > Hello Greg, > > > > > > On 5/12/20 5:15 PM, Greg KH wrote: > > > > On Mon, May 11, 2020 at 01:37:59PM +0530, Ritesh Harjani wrote: > > > > > Hello stable-list, > > > > > > > > > > I think this subjected patch [1] missed the below fixes tag. > > > > > I guess the subjected patch is only picked for 5.7. And > > > > > AFAIU, this patch will be needed for 5.6 as well. > > > > > > > > > > Could you please do the needful. > > > > > > > > > > Fixes: 244adf6426ee31a (ext4: make dioread_nolock the default) > > > > > > > > > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=626b035b816b61a7a7b4d2205a6807e2f11a18c1 > > > > > > > > This patch does not apply to the 5.6 kernel tree at all. Please provide > > > > a working backport if you wish to see it present there. > > > > > > Sorry if that's the case. > > > I tried both "git cherry-pick" and "git am" with patch mentioned @ [1] > > > to apply on branch "remotes/linux-stable/linux-5.6.y" of tree > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git > > > and it applied cleanly. > > > > > > Also, just noticed this patch in the queue. Is it that maybe you are > > > trying to apply it twice? > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-5.6/ext4-don-t-set-dioread_nolock-by-default-for-blocksi.patch > > > > Odd, it didn't have the "upstream" commit id, which is why I didn't see > > that it was applied already. > > > > Sasha, something went wrong with your scripts, you didn't sign-off on it > > either :( > > Crap, sorry. I'll fix it up. I already did :)