On Sat, May 02, 2020 at 04:22:31AM +0530, Ritesh Harjani wrote: > > > On 4/27/20 11:49 PM, Christoph Hellwig wrote: >> By moving FIEMAP_FLAG_SYNC handling to fiemap_prep we ensure it is >> handled once instead of duplicated, but can still be done under fs locks, >> like xfs/iomap intended with its duplicate handling. Also make sure the >> error value of filemap_write_and_wait is propagated to user space. > > > Forgot to remove filemap_write_and_wait() from > ext4_ioctl_get_es_cache() ? Fixed.