On Tue, Apr 28, 2020 at 09:48:08AM -0700, Christoph Hellwig wrote: > On Tue, Apr 28, 2020 at 06:45:24PM +0200, Lukas Czerner wrote: > > At the parsing phase of mount in the new mount api sb will not be > > available so allow sb to be NULL in ext4_msg and use that in > > handle_mount_opt(). > > > > Also change return value to appropriate -EINVAL where needed. > > Shouldn't mount-time messages be reported using the logfc and family > helpers from include/linux/fs_context.h? (which btw, have really > horrible over-generic names). I am sure it should at some point, but I am not really sure how ready it is at the moment. Last time I checked David told me not to bother using it yet. Is it ready yet David ? Should we be switching to it ? -Lukas
