On Mon, Apr 27, 2020 at 9:20 PM Christoph Hellwig <hch@xxxxxx> wrote: > > By moving FIEMAP_FLAG_SYNC handling to fiemap_prep we ensure it is > handled once instead of duplicated, but can still be done under fs locks, > like xfs/iomap intended with its duplicate handling. Also make sure the > error value of filemap_write_and_wait is propagated to user space. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Nice! Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> Thanks for fixing this, Amir.