On Sat, Apr 25, 2020 at 12:43 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Sat, Apr 25, 2020 at 12:11:59PM +0300, Amir Goldstein wrote: > > FWIW, I agree with you. > > And seems like Jan does as well, since he ACKed all your patches. > > Current patches would be easier to backport to stable kernels. > > Honestly, the proper fix is pretty much trivial. I wrote it up this > morning over coffee: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/fiemap-fix > > Still needs more testing, though. Very slick! I still think Ritesh's patches are easier for backporting because they are mostly contained within the ext4/overlayfs subsystems and your patch can follow up as interface cleanup. I would use as generic helper name generic_fiemap_checks() akin to generic_write_checks() and generic_remap_file_range_prep() => generic_remap_checks(). Thanks, Amir.
