On Fri, Apr 24, 2020 at 04:40:58PM -0700, Matthew Wilcox wrote: > On Sat, Apr 25, 2020 at 04:24:24AM +0530, Ritesh Harjani wrote: > > Ok, I see. > > Let me replace WARN() with below pr_warn() line then. If no objections, > > then will send this in a v2 with both patches combined as Darrick > > suggested. - (with Reviewed-by tags of Jan & Christoph). > > > > pr_warn("fibmap: this would truncate fibmap result\n"); > > We generally don't like userspace to be able to trigger kernel messages > on demand, so they can't swamp the logfiles. printk_ratelimited()? Or WARN_ON_ONCE... --D