Re: [PATCH] ext4: increase wait time needed before reuse of deleted inode numbers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon 13-04-20 22:39:25, Theodore Ts'o wrote:
> Current wait times have proven to be too short to protect against inode
> reuses that lead to metadata inconsistencies.
> 
> Now that we will retry the inode allocation if we can't find any
> recently deleted inodes, it's a lot safer to increase the recently
> deleted time from 5 seconds to a minute.
> 
> Google-Bug-Id: 36602237
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>

Looks good to me. You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/ext4/ialloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 9faaf32be5cc..4b8c9a9bdf0c 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -662,7 +662,7 @@ static int find_group_other(struct super_block *sb, struct inode *parent,
>   * block has been written back to disk.  (Yes, these values are
>   * somewhat arbitrary...)
>   */
> -#define RECENTCY_MIN	5
> +#define RECENTCY_MIN	60
>  #define RECENTCY_DIRTY	300
>  
>  static int recently_deleted(struct super_block *sb, ext4_group_t group, int ino)
> -- 
> 2.24.1
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux