On Tue, Apr 21, 2020 at 01:34:23PM -0700, Darrick J. Wong wrote: > On Tue, Apr 21, 2020 at 12:17:53PM -0700, ira.weiny@xxxxxxxxx wrote: > > From: Ira Weiny <ira.weiny@xxxxxxxxx> > > > > Update the Usage section to reflect the new individual dax selection > > functionality. > > [snip] > > + > > +The default state is 'inode'. Given underlying media support, the following > > +algorithm is used to determine the effective mode of the file S_DAX on a > > +capable device. > > + > > + S_DAX = FS_XFLAG_DAX; > > + > > + if (dax_mount == "always") > > + S_DAX = true; > > + else if (dax_mount == "off" > > Missing trailing parenthesis here. Done. > > > + S_DAX = false; > > + > > +To reiterate: Setting, and inheritance, continues to affect FS_XFLAG_DAX even > > +while the file system is mounted with a dax override. However, in-core inode > > +state (S_DAX) will continue to be overridden until the filesystem is remounted > > +with dax=inode and the inode is evicted." > > Trailing double-quote here. Fixed done. > > Otherwise, this looks good to me. thanks, Ira
