On Fri, Apr 10, 2020 at 12:16:35PM -0400, Theodore Y. Ts'o wrote: > On Thu, Apr 02, 2020 at 03:47:16PM +0200, Lukas Czerner wrote: > > We don't want to override system setting by changing the PATH. This > > should remain under administrator/user control. > > > > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx> > > The reason why the PATH was added is because most users don't have > /sbin or /usr/sbin in their PATH, and if they run "sudo e2scrub", > finding commands like lvcreate, lvremove, et. al., wouldn't be there. I don't understand, e2scrub should be in be in sbin as well, right ? Besides what if such user wants to run lvcreate, or lvremove ? This seems like a problem that should be fixed somewhere else. > > I suppose we could do something like > > PATH=$PATH:/sbin:/usr/sbin that's better than replacing it. -Lukas > > instead, but otherwise, users will see some unexpected failures. > > - Ted >
