Re: [PATCH] libext2fs: avoid pointer arithmetic on `void *`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Apr 4, 2020, at 10:53 PM, Michael Forney <mforney@xxxxxxxxxxx> wrote:
> 
> The pointer operand to the binary `+` operator must be to a complete
> object type.
> 
> Signed-off-by: Michael Forney <mforney@xxxxxxxxxxx>

Seems straight forward enough.  Not needed for GCC, but strictly correct.

Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>

> ---
> lib/ext2fs/csum.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/ext2fs/csum.c b/lib/ext2fs/csum.c
> index 8513d1ab..c2550365 100644
> --- a/lib/ext2fs/csum.c
> +++ b/lib/ext2fs/csum.c
> @@ -274,7 +274,7 @@ static errcode_t __get_dirent_tail(ext2_filsys fs,
> 		rec_len = translate(d->rec_len);
> 	}
> 
> -	if ((void *)d > ((void *)dirent + fs->blocksize))
> +	if ((char *)d > ((char *)dirent + fs->blocksize))
> 			return EXT2_ET_DIR_CORRUPTED;
> 	if (d != top)
> 		return EXT2_ET_DIR_NO_SPACE_FOR_CSUM;
> --
> 2.26.0
> 


Cheers, Andreas





Attachment: signature.asc
Description: Message signed with OpenPGP


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux