On Sun 15-03-20 13:15:20, Theodore Y. Ts'o wrote: > On Thu, Feb 13, 2020 at 11:16:02AM +0100, Jan Kara wrote: > > When clearing dir_index feature while metadata_csum is enabled, we have > > to rewrite checksums of all indexed directories to update checksums of > > internal tree nodes. > > > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > Thanks, applied. > > With regards to the enum, I agree with Jan that using an enum for > bitfields isn't a great fit. Also, in this case, where it's for a > static function and the definitions don't go beyond a single file, the > advantages of using an enum so we can have strong typing is much less > useful. > > One thing which I did notice when trying to test this patch is that > > mke2fs -t ext4 -d /usr/projects/e2fsprogs /tmp/foo.img 1G > > ...does not create any indexed directories. That's because the > changes to ext2fs_link() only teach e2fsprogs how to add a link to a > directory which is already indexing. We don't have code which takes a > directory with a single directory block and which doesn't have > directory indexing flag enabled, and converts to a indexed directory. Yes, I know and it's kind of deliberate because not all users of ext2fs_link() want that to happen (e.g. linking into lost+found). So I wasn't sure what a proper API for this functionality would be and decided to leave that decision for later. Maybe we could export the "optimize dir" functionality from e2fsck to be generally available in libext2fs? Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
