On Thu, Feb 13, 2020 at 11:15:58AM +0100, Jan Kara wrote: > Currently, ext2fs_mkdir() and ext2fs_symlink() update allocation bitmaps > and other information only close to the end of the function, in > particular after calling to ext2fs_link(). When ext2fs_link() will > support indexed directories, it will also need to allocate blocks and > that would cause filesystem corruption in case allocation info isn't > properly updated. So make sure ext2fs_mkdir() and ext2fs_symlink() > update allocation info before calling into ext2fs_link(). I'm not sure why there would be file system corruption if the allocation information isn't updated until later? Can you explain more? One problem with moving the alliocation updates earlier is that in case of errors, they need to be undone. To be fair, there are other missing error handling if there are failures, but this change would make things worse. - Ted
