On Fri, Feb 28, 2020 at 02:35:38PM -0600, Goldwyn Rodrigues wrote: > > Ah, okay. Now I understand what Christoph was saying. > > I suppose it is safe to remove iov_iter_reexpand(). I don't see any > other goto to this label which will have a non-zero copied value. > And we have already performed the iov_iter_revert(). I don't really understand the iov_iter complexities either, at least not without spending sifnificant time with the implementation. But the important thing is that you document the changes in behavior and your findings on why you think it is safe.