Re: [PATCH 3/9] e2fsck: avoid mallinfo() if over 2GB allocated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 06, 2020 at 06:09:40PM -0700, Andreas Dilger wrote:
> Don't use mallinfo() for determining the amount of memory used if it
> is over 2GB.  Otherwise, the signed ints used by this interface can
> can overflow and return garbage values.  This makes the actual amount
> of memory used by e2fsck misleading and hard to determine.
> 
> Instead, use brk() to get the total amount of memory allocated, and print
> this if the more detailed mallinfo() information is not suitable for use.
> 
> There does not appear to be a mallinfo64() variant of this function.
> There does appear to be an abomination named malloc_info() that writes
> XML-formatted malloc stats to a FILE stream that would need to be read
> and parsed in order to get these stats, but that doesn't seem worthwhile.
> 
> Signed-off-by: Andreas Dilger <adilger@xxxxxxxxxxxxx>
> Reviewed-by: Shilong Wang <wshilong@xxxxxxx>
> Lustre-bug-id: https://jira.whamcloud.com/browse/LU-13197

Applied, thanks.

					- Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux