On 29/02/2020 17:42, Theodore Y. Ts'o wrote: > On Sat, Feb 29, 2020 at 12:39:34AM +0000, Colin Ian King wrote: >> Hi, >> >> static analysis with Coverity has found an issue in function >> ext4_convert_meta_bg() with the following commit >> >> commit 1c6bd7173d66b3dfdefcedb38cabc1fb03997509 >> Author: Theodore Ts'o <tytso@xxxxxxx> >> Date: Thu Sep 13 10:19:24 2012 -0400 >> >> ext4: convert file system to meta_bg if needed during resizing >> >> The analysis is as follows: >> >> 1898 >> 1899 errout: >> 1900 ret = ext4_journal_stop(handle); >> 1901 if (!err) >> >> Unused value (UNUSED_VALUE)assigned_value: Assigning value from ret to >> err here, but that stored value is not used. >> >> 1902 err = ret; >> 1903 return ret; > > Line 1903 should be "return err". > > Want to send a patch, or shall I just commit the fix? > > - Ted > I don't mind if you commit the fix, I wasn't sure what the appropriate fix was, so I kudos to you Ted for that. Colin
