On Wed 26-02-20 12:10:02, yangerkun wrote:
> Run generic/388 with journal data mode sometimes may trigger the warning
> in ext4_invalidatepage. Actually, we should use the matching invalidatepage
> in ext4_writepage.
>
> Signed-off-by: yangerkun <yangerkun@xxxxxxxxxx>
Thanks for the patch! It looks good to me. You can add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index fa0ff78dc033..78e805d42ada 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -1974,7 +1974,7 @@ static int ext4_writepage(struct page *page,
> bool keep_towrite = false;
>
> if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) {
> - ext4_invalidatepage(page, 0, PAGE_SIZE);
> + inode->i_mapping->a_ops->invalidatepage(page, 0, PAGE_SIZE);
> unlock_page(page);
> return -EIO;
> }
> --
> 2.23.0.rc2.8.gff66981f45
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
