On Thu, Feb 06, 2020 at 11:52:17AM -0600, Eric Sandeen wrote: > On 1/30/20 7:21 AM, Lukas Czerner wrote: > > gcc version 10 changed the default from -fcommon to -fno-common and as a > > result e2fsprogs unit tests fail because tst_libext2fs.c end up with a > > build error. > > > > This is because it defines two global variables debug_prog_name and > > extra_cmds that are already defined in debugfs/debugfs.c. With -fcommon > > linker was able to resolve those into the same object, however with > > -fno-common it's no longer able to do it and we end up with > > multiple definition errors. > > > > Fix the problem by creating an extern declaration of said variables in > > debugfs.h and just setting them in tst_libext2fs.c without additional > > declaration. > > > > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx> > > This looks fine to me. > > Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> > > Is there any need to fix the one in lib/ext2fs/extent.c ? It's only there > under #ifdef DEBUG though. Yeah, but if we ever want to use DEBUG macro it would fail with -fno-common. Uff, I guess I have to fix this one as well. Thanks Eric, -Lukas > > Thanks, > -Eric >
